Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add STDEV() aggregate function #1553

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ullingerc
Copy link
Collaborator

@ullingerc ullingerc commented Oct 14, 2024

This PR adds a new aggregate function STDEV(X) which computes the (sample) standard deviation, such that a user will not have to repetitively type math:sqrt(sum(math:pow((X - avg(X)), 2)) / (count(*) - 1)). This is not part of the SPARQL standard, but also doesn't cause any conflicts.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 90.27778% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.96%. Comparing base (bf36257) to head (bc81df7).

Files with missing lines Patch % Lines
src/engine/sparqlExpressions/StdevExpression.h 90.00% 3 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1553      +/-   ##
==========================================
- Coverage   88.96%   88.96%   -0.01%     
==========================================
  Files         366      367       +1     
  Lines       33256    33328      +72     
  Branches     3729     3735       +6     
==========================================
+ Hits        29587    29650      +63     
- Misses       2439     2442       +3     
- Partials     1230     1236       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An initial round of reviews.

src/engine/sparqlExpressions/StdevExpression.h Outdated Show resolved Hide resolved
src/engine/GroupBy.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants